Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properties rework #32

Merged
merged 63 commits into from
May 11, 2023
Merged

Properties rework #32

merged 63 commits into from
May 11, 2023

Conversation

opekope2
Copy link
Owner

@opekope2 opekope2 commented Apr 9, 2023

OptiGUI is getting its own properties files, independent of the OptiFine ones.

This will allow resource pack creators to add more advanced features than OptiFine supports, which would be impossible to cram into the OptiFine properties, while making the resource pack compatible with OptiFine.

This, however, brings a breaking change: support for every OptiGUI extension feature (added in v1.1.0 or the 2.0.0 betas) will be removed from the OptiFine format, and instead, these will be available throught the new OptiGUI format.

The new format will be similar to the OptiFine format, and just as simple. A sneak peek of what's planned (as it's not yet finalized):

container=chest
_barrel=true
texture=<replacement.png>

becomes

[barrel]
texture=<replacement.png>

(While also fixing some annoying things with OptiFine's format)

OptiGUI will continue to support the OptiFine format.

@opekope2 opekope2 added the enhancement New feature or request label Apr 9, 2023
@opekope2 opekope2 added this to the OptiGUI 2.0.0 release milestone Apr 9, 2023
@opekope2 opekope2 self-assigned this Apr 9, 2023
This filter will be needed for the OptiGUI format
Replace Root filter in ResourceLoader with it as it has the same functionality
@opekope2 opekope2 mentioned this pull request Apr 10, 2023
@opekope2 opekope2 marked this pull request as ready for review April 20, 2023 21:18
@opekope2
Copy link
Owner Author

opekope2 commented May 6, 2023

At this point, if a resource pack only contains texture.<path>, but no texture, it will log a warning. I plan to make it toggle-able in the future, and I also plan to make a toggle-able GUI to show the warnings (in a future release)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant