generated from SmushyTaco/Example-Mod
-
-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Properties rework #32
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Remove properties from Resource Add inputStream to ResourceReader
Add dependency for INI handling
Deprecate old behavior
This filter will be needed for the OptiGUI format Replace Root filter in ResourceLoader with it as it has the same functionality
Closed
Refactor OptiGlue
Fix texture things TODO: log warnings
Update tests to the new implementation
Now every preprocessor accepts its own type instead of Entity or BlockEntity
Use computed property to not instantly crash when the resource doesn't exist
Move wildcard conversion
Fix some cases when general properties are not getting copied
At this point, if a resource pack only contains |
This was referenced May 15, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OptiGUI is getting its own properties files, independent of the OptiFine ones.
This will allow resource pack creators to add more advanced features than OptiFine supports, which would be impossible to cram into the OptiFine properties, while making the resource pack compatible with OptiFine.
This, however, brings a breaking change: support for every OptiGUI extension feature (added in v1.1.0 or the 2.0.0 betas) will be removed from the OptiFine format, and instead, these will be available throught the new OptiGUI format.
The new format will be similar to the OptiFine format, and just as simple. A sneak peek of what's planned (as it's not yet finalized):
becomes
(While also fixing some annoying things with OptiFine's format)
OptiGUI will continue to support the OptiFine format.