Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(auth): Added a User Auth configuration setting to disable/enable… #605

Merged
merged 2 commits into from
May 24, 2022

Conversation

madhavilosetty-intel
Copy link
Contributor

@madhavilosetty-intel madhavilosetty-intel commented May 3, 2022

… MPS auth

AB#7066
AB#7075
AB#7083

PR Checklist

  • Unit Tests have been added for new changes
  • API tests have been updated if applicable
  • All commented code has been removed
  • If you've added a dependency, you've ensured license is compatible with Apache 2.0 and clearly outlined the added dependency.

What are you changing?

Anything the reviewer should know when reviewing this PR?

If the there are associated PRs in other repositories, please link them here (i.e. open-amt-cloud-toolkit/repo#365 )

@codecov
Copy link

codecov bot commented May 3, 2022

Codecov Report

Merging #605 (4ba032a) into main (1d522d2) will increase coverage by 1.17%.
The diff coverage is 65.21%.

❗ Current head 4ba032a differs from pull request most recent head 163050c. Consider uploading reports for the commit 163050c to get more accurate results

@@            Coverage Diff             @@
##             main     #605      +/-   ##
==========================================
+ Coverage   91.72%   92.90%   +1.17%     
==========================================
  Files          68       68              
  Lines        3035     3044       +9     
  Branches      520      524       +4     
==========================================
+ Hits         2784     2828      +44     
+ Misses        244      209      -35     
  Partials        7        7              
Impacted Files Coverage Δ
src/index.ts 50.00% <57.89%> (+50.00%) ⬆️
src/logging/messages.ts 100.00% <100.00%> (ø)
src/routes/auth/login.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1d522d2...163050c. Read the comment docs.

.mpsrc Outdated Show resolved Hide resolved
@madhavilosetty-intel madhavilosetty-intel force-pushed the 4536-Disable_JWT_User_Auth_Configuration branch from 04c20bb to e79bb87 Compare May 3, 2022 16:52
matt-primrose
matt-primrose previously approved these changes May 3, 2022
src/index.ts Outdated Show resolved Hide resolved
@madhavilosetty-intel madhavilosetty-intel force-pushed the 4536-Disable_JWT_User_Auth_Configuration branch 4 times, most recently from dbc8cd0 to 6f5d8ff Compare May 18, 2022 22:22
@madhavilosetty-intel madhavilosetty-intel force-pushed the 4536-Disable_JWT_User_Auth_Configuration branch from 6f5d8ff to 827b11c Compare May 18, 2022 23:45
@rsdmike rsdmike merged commit 897e9f2 into main May 24, 2022
@rsdmike rsdmike deleted the 4536-Disable_JWT_User_Auth_Configuration branch May 24, 2022 16:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Create configuration parameter to disable "Auth" Service from MPS
3 participants