Skip to content
This repository has been archived by the owner on Feb 1, 2024. It is now read-only.

Add searchability to embed config #1598

Merged
merged 1 commit into from Jan 26, 2022
Merged

Conversation

TaiWilkin
Copy link
Contributor

@TaiWilkin TaiWilkin commented Jan 24, 2022

Overview

Edit embed field config to allow marking a field as searchable and
add model and API support for persistence.

Connects #1533

Demo

Screen Shot 2022-01-24 at 11 25 31 AM

Screen Shot 2022-01-24 at 11 57 16 AM

Notes

Adding the checkbox to the right of the fields input caused the draggability buttons to wrap to the next row on certain screen sizes. I adjusted the layout / breakpoints to move the embed code box above the fields list on smaller screen sizes.

The new text_search_label field has been added to the embed config model, but hasn't yet been added to the embed config page. See #1534 for next steps.

Testing Instructions

./scripts/manage batch_process --list-id 16 --action parse
./scripts/manage batch_process --list-id 16 --action geocode
./scripts/manage batch_process --list-id 16 --action match
  • Navigate to settings and select the Embed tab.
  • Select several fields to be 'included', then check 'searchable' for them. Refresh the page and confirm they are still included and searchable.
  • Uncheck the left checkbox for a field that is searchable and note that the 'searchable' checkbox is unchecked.
  • Use 'select all' to uncheck all checkboxes and note that all searchable checkboxes are unchecked. Refresh the page to confirm persistence.
  • At various page sizes, hover over the list items to confirm that the draggable buttons render appropriately.
  • Further experiment with the embed config and field settings to confirm that the config page behaves as expected.

Checklist

  • fixup! commits have been squashed
  • CI passes after rebase
  • CHANGELOG.md updated with summary of features or fixes, following Keep a Changelog guidelines

Copy link
Contributor

@caseycesari caseycesari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small things, but otherwise working well.

src/app/src/components/EmbeddedMapFieldsConfig.jsx Outdated Show resolved Hide resolved
src/app/src/components/EmbeddedMapFieldsConfig.jsx Outdated Show resolved Hide resolved
@TaiWilkin
Copy link
Contributor Author

Thanks for the feedback! I've made the suggested style changes and it's ready for another look.

Copy link
Contributor

@lederer lederer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice improvements. Thank you. Added a couple more and then that should do it.

Copy link
Contributor

@caseycesari caseycesari left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@caseycesari caseycesari assigned TaiWilkin and unassigned caseycesari Jan 25, 2022
Edit embed field config to allow marking a field as searchable and
add model and API support for persistence.
@TaiWilkin
Copy link
Contributor Author

TaiWilkin commented Jan 26, 2022

Thank you for all the great feedback!

@TaiWilkin TaiWilkin merged commit 040bc38 into develop Jan 26, 2022
@TaiWilkin TaiWilkin deleted the tw/update-embed-config-model branch January 26, 2022 17:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants