This repository has been archived by the owner on Feb 1, 2024. It is now read-only.
Fix vector tile map crashes on login/logout #837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a bug whereby the vector tile map would crash on logging in or logging out caused by a missing check to ensure that the map object existed before calling getZoom. Adjust it to use the stored zoom state instead.
kellyi
force-pushed
the
ki/fix-map-crashes
branch
from
bb4c20c
to
6415734
Compare
|
Looking at this now. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Fix a bug whereby the vector tile map would crash on logging in or
logging out caused by a missing check to ensure that the map object
existed before calling getZoom. Adjust it to use the stored zoom state
instead.
Connects #822
Notes
Fixing this uncovered another quirk whereby we are clearing the existing facilities data on logout, along with the filter settings. This is how the existing map setup also works, so I did not try to address it here and will make another card for fixing it.
Testing Instructions
Checklist
fixup!commits have been squashed