Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rounding not enough and too much in hte wrong place #177

Closed
durs125 opened this issue Jun 14, 2017 · 5 comments
Closed

rounding not enough and too much in hte wrong place #177

durs125 opened this issue Jun 14, 2017 · 5 comments

Comments

@durs125
Copy link

durs125 commented Jun 14, 2017

The change in the budget is rounded to the nearest percent. It will say no change if the change was only 0.4% in the end screen. I think rounding is not appropriate in this case. I think we need 1 decimal space.

For some reason, after hitting -.1 three times, it reads -.30000000004. In several other cases it also has over 5 decimal spaces.

@mateoclarke
Copy link

@durs125 Can you share a screen shoot and url of where this happens? That will make it easier to reproduce.

@mateoclarke mateoclarke added this to the June 2017 milestone Jun 14, 2017
@twentysixmoons
Copy link
Contributor

I think there are 2 issues here so I'm going to break these out.

1.) Here is one, where the decimal place goes over too much. When you're in the individual department services pages and you increase or decrease the decimal places, you occasionally get a large number shown below.

image

We would like there to only be 2 decimal places and the number be rounded.

@twentysixmoons
Copy link
Contributor

twentysixmoons commented Jun 16, 2017

  1. I think this screenshot explains what David was referencing for the first point.
    image

@durs125
Copy link
Author

durs125 commented Jun 19, 2017

Yes, Great example

smonami added a commit to smonami/budgetparty that referenced this issue Jun 21, 2017
smonami added a commit to smonami/budgetparty that referenced this issue Jun 21, 2017
smonami added a commit to smonami/budgetparty that referenced this issue Jun 21, 2017
…places to 2

fixes open-austin/budgetparty/open-austin#177 by removing rounding and restricting the decimal places to 2
smonami added a commit to smonami/budgetparty that referenced this issue Jun 21, 2017
@smonami
Copy link
Contributor

smonami commented Jun 22, 2017

Sorry for the multiple commits. This 2 parts issue has been fixed.
Also, please let me know if you need a separate pull request.

Edit: Added pull request.
#188

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants