-
-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensuring completion-listener.ts listen to a single close event emitte… #464
Merged
Merged
Changes from 2 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
37156a9
Ensuring completion-listener.ts listen to a single close event emitte…
2eee2c2
Format.
5c9b16f
-Apply Latest.
f5dd736
Remove IPC support
1c03da7
Apply PR changes.
9c8edfb
Faked.
f81fa00
Exited
bfd2094
.
6992c26
Merge branch 'open-cli-tools:main' into main
odeadglaz c86d247
Check command state, instead of close event state
gustavohenke 54818fb
Use emitFakeCloseEvent util more
gustavohenke File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that replacing these lines with
Rx.combineLatest()
+ removing thetake(1)
above can achieve retaining the last emitted close event.We can then also fix your edge case from #464 (comment) with a
filter()
operator that checks if every command is indeed closed.This means waiting until every command emits another close event.
WDYT?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yea that sounds legit, at-least the first part, seems like
combineLatest
can do the job 👍 Ill try to change the implementation accordinglyThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@gustavohenke I've pushed the changes, the only drawback using the
combineLatest
is that it actually keep the close events according to the registered stream and not by the actual order they were emitted, So beside accepting your offer I also added amap
to sort it via thestartingDate
of the event, would love to hear if you got any better suggestion here 👍