⚠️ Update OCM APIs and apply Rollout Strategy API changes #310
Conversation
|
/assign @haoqing0110 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #310 +/- ##
==========================================
+ Coverage 61.61% 61.63% +0.02%
==========================================
Files 132 132
Lines 13956 13956
==========================================
+ Hits 8599 8602 +3
+ Misses 4592 4589 -3
Partials 765 765
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
serngawy
force-pushed
the
updateRollout
branch
2 times, most recently
from
99901ac
to
5b32a0b
Compare
| @@ -799,6 +856,9 @@ func TestAddonConfigReconcile(t *testing.T) { | |||
| {GroupName: "group1"}, | |||
| }, | |||
| }, | |||
| RolloutConfig: clusterv1alpha1.RolloutConfig{ | |||
There was a problem hiding this comment.
Will the test case report error if not adding None explicitly? since I though empty string will works as None refer to https://github.com/open-cluster-management-io/api/blob/main/cluster/v1alpha1/helpers.go#L554.
There was a problem hiding this comment.
Create a fix PR open-cluster-management-io/api#295, I think we should allow the user not define ProgressivePerGroup field and just use the default value.
There was a problem hiding this comment.
okay, I agree. will update the API commit version based on the above PR fix.
serngawy
force-pushed
the
updateRollout
branch
3 times, most recently
from
fcd9445
to
98fde64
Compare
|
/lgtm |
Signed-off-by: melserngawy <melserng@redhat.com>
serngawy
force-pushed
the
updateRollout
branch
from
98fde64
to
502a0b0
Compare
|
/approve Leave to @haoqing0110 for final review. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: qiujian16, serngawy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
openshift-merge-bot
bot
merged commit 615f5a4
into
open-cluster-management-io:main
…pen-cluster-management-io#310) Signed-off-by: Jon Jackson <jonjacks@redhat.com> Signed-off-by: Jon Jackson <jonjacks@redhat.com>
…-management-io#310) Signed-off-by: xuezhaojun <zxue@redhat.com>
Summary
Update OCM APIs and apply Rollout Strategy API changes
Related issue(s)
Fixes #