Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🌱 Update the OCM/API denpendency. #313

Conversation

xuezhaojun
Copy link
Member

Summary

Related issue(s)

Fixes #

@xuezhaojun
Copy link
Member Author

/assign @qiujian16

Copy link

codecov bot commented Nov 16, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3882b1d) 61.61% compared to head (5f5185e) 61.61%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #313   +/-   ##
=======================================
  Coverage   61.61%   61.61%           
=======================================
  Files         132      132           
  Lines       13956    13956           
=======================================
  Hits         8599     8599           
+ Misses       4592     4591    -1     
- Partials      765      766    +1     
Flag Coverage Δ
unit 61.61% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

openshift-ci bot commented Nov 16, 2023

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: xuezhaojun
Once this PR has been reviewed and has the lgtm label, please ask for approval from qiujian16. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@qiujian16
Copy link
Member

cc @haoqing0110 this relates to the rollout

Signed-off-by: xuezhaojun <zxue@redhat.com>
@xuezhaojun
Copy link
Member Author

cc @haoqing0110 this relates to the rollout

The related PR: open-cluster-management-io/api#281 Please take a look! Thanks!

@xuezhaojun
Copy link
Member Author

Overlap with this PR: #310

@xuezhaojun xuezhaojun closed this Nov 16, 2023
@xuezhaojun xuezhaojun deleted the update-api-dependency branch December 19, 2023 07:20
mprahl pushed a commit to mprahl/OCM that referenced this pull request Mar 14, 2024
Signed-off-by: Zhiwei Yin <zyin@redhat.com>
mprahl pushed a commit to mprahl/OCM that referenced this pull request Mar 14, 2024
Signed-off-by: xuezhaojun <zxue@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants