add PlacementConditionMisconfigured #72
Conversation
|
@haoqing0110: PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
haoqing0110
force-pushed
the
br_misconfig
branch
from
467b5e5
to
1d6a01c
Compare
haoqing0110
force-pushed
the
br_misconfig
branch
2 times, most recently
from
01154cf
to
b9bbd13
Compare
|
|
||
| if err != nil { | ||
| return nil, err | ||
| if status.Code() == framework.Error || status.Code() == framework.Misconfigured { |
| Type: clusterapiv1beta1.PlacementConditionMisconfigured, | ||
| Status: metav1.ConditionTrue, | ||
| Reason: "Misconfigured", | ||
| Message: "Placement configurations check failed", |
There was a problem hiding this comment.
message should add the plugin name
|
|
||
| if err != nil { | ||
| return nil, err | ||
| if status.Code() == framework.Error || status.Code() == framework.Misconfigured { |
| if status.Code() == framework.Error || status.Code() == framework.Misconfigured { | ||
| return nil, status | ||
| } else if status.Code() == framework.Warning { | ||
| finalStatus = status |
There was a problem hiding this comment.
add a warning log or a event for placement.
haoqing0110
force-pushed
the
br_misconfig
branch
from
b9bbd13
to
99ddc78
Compare
Signed-off-by: haoqing0110 <qhao@redhat.com>
haoqing0110
force-pushed
the
br_misconfig
branch
from
99ddc78
to
c896583
Compare
Signed-off-by: haoqing0110 <qhao@redhat.com>
haoqing0110
changed the title
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: haoqing0110, qiujian16 The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm |
Ref: open-cluster-management-io/ocm#66