Support GSM8k evaluation with tools by Lagent and LangChain #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/
You can install pre-commit hooks to automatically fix this issue: |
mzr1996
force-pushed
the
mzr/support-agents
branch
from
85b3446
to
6942c84
Compare
mzr1996
force-pushed
the
mzr/support-agents
branch
from
6942c84
to
d3e7fa2
Compare
mzr1996
changed the title
gaotongxiao
reviewed
Sep 14, 2023
opencompass/models/lagent.py
Outdated
|
|
||
| self.agent = REGISTRY.build(agent_cfg) | ||
|
|
||
| def chat(self, user_input, ice=None) -> Tuple[str, dict]: |
There was a problem hiding this comment.
ice is not used? Same for langchain
| REGISTRY = Registry('helper') | ||
|
|
||
|
|
||
| class LagentAgent: |
There was a problem hiding this comment.
May need a BaseAgent - if the design is general enough
There was a problem hiding this comment.
Need docstr for the class (same for langchain)
| super().__init__() | ||
| self.fail_words = fail_words | ||
|
|
||
| def score(self, predictions: List): |
There was a problem hiding this comment.
Suggested change
| def score(self, predictions: List): | |
| def score(self, predictions: List, references: List): |
Following the protocol though it's not used
| highest_idx = np.where(scores == scores.max())[0].tolist() | ||
| return random.choice(highest_idx) | ||
|
|
||
| def _openai_function(self, msg: str, max_out_len: int, functions: dict, |
There was a problem hiding this comment.
Can it be implemented as an OpenAIFunc wrapper?
Leymore
force-pushed
the
mzr/support-agents
branch
from
643b13f
to
4e5a49b
Compare
Leymore
approved these changes
Sep 22, 2023
1 task
go-with-me000
pushed a commit
to go-with-me000/opencompass
that referenced
this pull request
Oct 9, 2023
…pass#277) * Support GSM8k evaluation with tools by Lagent and LangChain * Avoid to use MMEngine new feature * update document --------- Co-authored-by: Leymore <zfz-960727@163.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for your contribution and we appreciate it a lot. The following instructions would make your pull request more healthy and more easily get feedback. If you do not understand some items, don't worry, just make the pull request and seek help from maintainers.
Motivation
Please describe the motivation of this PR and the goal you want to achieve through this PR.
Modification
Please briefly describe what modification is made in this PR.
BC-breaking (Optional)
Does the modification introduce changes that break the backward compatibility of the downstream repositories?
If so, please describe how it breaks the compatibility and how the downstream projects should modify their code to keep compatibility with this PR.
Use cases (Optional)
If this PR introduces a new feature, it is better to list some use cases here and update the documentation.
Checklist
Before PR:
After PR: