-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding code of conduct and contribute guide #30
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I would change the suggested port for the kind registry to 5000 as the ocm-controller starts a registry by default on port 5001 🛩️
Oh nice find. :D |
The only problem is that the Something like:
|
I agree. Should we adjust the default too? |
Humm hummmmm... Sure. We have to do that in the other controllers as well then. :) |
Hahaha, check this out. The replication controller already defaults to 5000... :D
|
That address should really point at Kubernetes service name for the deployment but be overridable for local testing, similar to flux kustomization and source controller. |
You usually do that in the deployment, right? To point to the right service name and DNS record... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
No description provided.