-
Notifications
You must be signed in to change notification settings - Fork 0
Normalise name and description fields with language codes #4
Comments
One implementation option would be to add a method to ExtensionVersion in extension_registry.py to normalize the metadata in extension.json. If so, in terms of API, I think it makes sense for the existing |
I have done this as a seperate def for now, with a note saying it could be pushed upstream. I agree it would be good to, but there is a slight problem to overcome first in that the code upstream will always download the file, or use it's in memory cache. In this package we store files to disk, and I've already got it so that in some cases it re-uses the files on disk between runs, thus saving downloads and time. There was a comment elsewhere about extracting code upstream - I'm sure it can be done with a little thought about the API design. Will bear this case in mind. |
For sure - it will likely be simpler to consider API changes once this repo's needs are fleshed out through further implementation :) |
Some earlier versions of the extensions did not have language codes, so that currently we get
The output of this package should be normalized so there is always a language code there.
The text was updated successfully, but these errors were encountered: