Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Django caching for explore pages #90

Open
jpmckinney opened this issue Oct 6, 2020 · 5 comments
Open

Use Django caching for explore pages #90

jpmckinney opened this issue Oct 6, 2020 · 5 comments

Comments

@jpmckinney
Copy link
Member

jpmckinney commented Oct 6, 2020

lib-cove is very slow: open-contracting/lib-cove-oc4ids#23

There is no reason to re-validate the data on each request. This should be cached.

I think we can just use the per-site cache, which is i18n-aware: https://docs.djangoproject.com/en/3.1/topics/cache/#the-per-site-cache Please setup memcached on the server.

@jpmckinney
Copy link
Member Author

@duncandewhurst Please add this to the sprint. It can be done the same for CoVE OCDS and CoVE OC4IDS.

@Bjwebb
Copy link
Contributor

Bjwebb commented Oct 8, 2020

For CoVE OCDS, we have a version switcher on the explore pages, that causes the same url to return different content before/after the switch, so I think we need to be careful how we apply caching (e.g. by putting the version number into the cache key).

@duncandewhurst
Copy link
Contributor

@jpmckinney is this still relevant in respect of the forthcoming work on the frontend?

@jpmckinney
Copy link
Member Author

Yes, caching remains relevant.

@jpmckinney
Copy link
Member Author

Related: #203

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants