Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

207 authorization bugs #220

Merged
merged 13 commits into from
Nov 28, 2023
Merged

207 authorization bugs #220

merged 13 commits into from
Nov 28, 2023

Conversation

yolile
Copy link
Member

@yolile yolile commented Nov 28, 2023 •
edited
Loading

Closes #207

jpmckinney
jpmckinney reviewed Nov 28, 2023
View reviewed changes
Copy link
Member

@jpmckinney jpmckinney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple comments.

I'm not familiar enough with the workflow, so I assume the statuses removed from USER_CAN_EDIT_AWARD_BORROWER_DATA and the new guards to upload_compliance, download_application and update_apps_send_notifications are correct.

app/routers/downloads.py Outdated Show resolved Hide resolved
app/routers/guest/applications.py Outdated Show resolved Hide resolved
@yolile
Copy link
Member Author

yolile commented Nov 28, 2023

the statuses removed from USER_CAN_EDIT_AWARD_BORROWER_DATA

Yes, in the past this same list was used for listing applications, for example, now it is only used for the editing endpoints so we only need the actual editable status.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 28, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 7023047994

  • 23 of 23 (100.0%) changed or added relevant lines in 3 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage decreased (-0.006%) to 86.17%
Files with Coverage Reduction New Missed Lines %
app/routers/guest/applications.py 1 91.0%
Totals Coverage Status
Change from base Build 7020146929: -0.006%
Covered Lines: 2000
Relevant Lines: 2321
💛 - Coveralls

@jpmckinney jpmckinney mentioned this pull request Nov 28, 2023
Closed
jpmckinney
jpmckinney approved these changes Nov 28, 2023
View reviewed changes
Copy link
Member

@jpmckinney jpmckinney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just double-check my merge conflict resolution: 8be9260

@yolile yolile merged commit 781c9be into main Nov 28, 2023
5 checks passed
@yolile yolile deleted the 207-authorization-bugs branch November 28, 2023 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpmckinney jpmckinney jpmckinney approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Double-check authorization and workflow logic
2 participants
@yolile @jpmckinney