Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LinkedRelease.tag required in the JSON schema but not in the schema reference documentation #328

Closed
duncandewhurst opened this issue May 23, 2021 · 3 comments · Fixed by #360
Closed

LinkedRelease.tag required in the JSON schema but not in the schema reference documentation #328

duncandewhurst opened this issue May 23, 2021 · 3 comments · Fixed by #360
Labels
bug Something isn't working documentation This issue relates to the documentation
Milestone
Iterative improve...

Comments

@duncandewhurst
Copy link
Contributor

tag is required in the schema and is shown in bold in the schema browser , as expected. However, in the schema reference, tag is not required.

cc @odscrachel
@duncandewhurst duncandewhurst added bug Something isn't working documentation This issue relates to the documentation labels May 23, 2021
@jpmckinney
Copy link
Member

Can you also report the bug on https://github.com/OpenDataServices/sphinxcontrib-opendataservices-jsonschema ?

@duncandewhurst duncandewhurst mentioned this issue May 24, 2021
Closed
@duncandewhurst duncandewhurst added this to the 0.9.4 milestone Nov 24, 2021
@Bjwebb
Copy link
Contributor

Bjwebb commented Jul 21, 2022

@duncandewhurst How does this look? https://standard.open-contracting.org/staging/infrastructure/tmp-328-tag-not-required-git-requirement/en/reference/schema/#linkedrelease

@duncandewhurst
Copy link
Contributor Author

Looks great. Thank you!

Bjwebb added a commit that referenced this issue Jul 22, 2022
@Bjwebb
requirements: Update sphinxcontrib-opendataservices-jsonschema to 0.5.0
fd5f1a6 
Fixes #328
Relevant PR
OpenDataServices/sphinxcontrib-opendataservices-jsonschema#40
Bjwebb added a commit that referenced this issue Jul 22, 2022
@Bjwebb
requirements: Update sphinxcontrib-opendataservices-jsonschema to 0.5.0
b9e34d2 
Fixes #328
Relevant PR
OpenDataServices/sphinxcontrib-opendataservices-jsonschema#40
@Bjwebb Bjwebb mentioned this issue Jul 22, 2022
Merged
jpmckinney pushed a commit that referenced this issue Dec 15, 2022
@Bjwebb @jpmckinney
requirements: Update sphinxcontrib-opendataservices-jsonschema to 0.5.0
cd64211 
Fixes #328
Relevant PR
OpenDataServices/sphinxcontrib-opendataservices-jsonschema#40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working documentation This issue relates to the documentation
Projects
None yet
Milestone
Iterative improvements
3 participants
@Bjwebb @jpmckinney @duncandewhurst