ci: Use PYTHONWARNINGS=error

open-contracting · Apr 6, 2022 · 40ce2e5 · 40ce2e5
1 parent 02cb5ca
commit 40ce2e5
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -22,7 +22,9 @@ jobs:
           restore-keys: |
             ${{ runner.os }}-pip-
       - run: pip install .[test]
-      - run: pytest --cov jscc --vcr-record=none tests
+      - env:
+          PYTHONWARNINGS: error
+        run: pytest --cov jscc --vcr-record=none tests
       - env:
           GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
         run: coveralls --service=github
diff --git a/tests/test_checks.py b/tests/test_checks.py
@@ -1,6 +1,7 @@
 import contextlib
 import json
 import os
+import warnings
 
 import pytest
 from jsonref import JsonRef
@@ -236,10 +237,11 @@ def allow_missing(pointer):
 
 def test_validate_ref_pass():
     filepath = os.path.join('schema', 'schema.json')
-    with pytest.warns(None) as records:
-        errors = validate_ref(path(filepath), parse(filepath))
 
-    assert errors == len(records) == 0
+    with warnings.catch_warnings():
+        warnings.simplefilter('error')
+
+        errors = validate_ref(path(filepath), parse(filepath))
 
 
 def test_validate_ref_fail():