tests: Add tests for FilesStore.spider_closed()

open-contracting · Aug 18, 2022 · 594b782 · 594b782
1 parent 81e9572
commit 594b782
Show file tree

Hide file tree

Showing 2 changed files with 35 additions and 1 deletion.
diff --git a/kingfisher_scrapy/extensions/files_store.py b/kingfisher_scrapy/extensions/files_store.py
@@ -1,3 +1,4 @@
+import math
 import os
 
 from scrapy import signals
@@ -48,7 +49,7 @@ def spider_closed(self, spider):
         path = os.path.join(self.directory, self.relative_crawl_directory(spider))
 
         message = f'The data is available at: {path}'
-        message_length = len(message) + 1
+        message_length = math.ceil(len(message) / 2) * 2
         title_length = message_length // 2 - 8
 
         spider.logger.info(f"+-{'-' * title_length } DATA DIRECTORY {'-' * title_length }-+")

diff --git a/tests/extensions/test_files_store.py b/tests/extensions/test_files_store.py
@@ -1,3 +1,4 @@
+import logging
 import os
 from tempfile import TemporaryDirectory
 from unittest.mock import Mock
@@ -37,6 +38,38 @@ def test_spider_opened(job, tmpdir):
         assert not os.path.exists(path)
 
 
+def test_spider_closed_odd(caplog):
+    spider = spider_with_files_store('1')
+
+    extension = FilesStore.from_crawler(spider.crawler)
+    with caplog.at_level(logging.INFO):
+        extension.spider_closed(spider)
+
+        assert [record.message for record in caplog.records] == [
+            '+----------------- DATA DIRECTORY -----------------+',
+            '|                                                  |',
+            '| The data is available at: 1/test/20010203_040506 |',
+            '|                                                  |',
+            '+--------------------------------------------------+',
+        ]
+
+
+def test_spider_closed_even(caplog):
+    spider = spider_with_files_store('22')
+
+    extension = FilesStore.from_crawler(spider.crawler)
+    with caplog.at_level(logging.INFO):
+        extension.spider_closed(spider)
+
+        assert [record.message for record in caplog.records] == [
+            '+------------------ DATA DIRECTORY ------------------+',
+            '|                                                    |',
+            '| The data is available at: 22/test/20010203_040506  |',
+            '|                                                    |',
+            '+----------------------------------------------------+',
+        ]
+
+
 @pytest.mark.parametrize('sample,path', [
     (None, os.path.join('test', '20010203_040506', 'file.json')),
     ('true', os.path.join('test_sample', '20010203_040506', 'file.json')),