Skip to content

Commit

Permalink
Apply suggestions from code review
Browse files Browse the repository at this point in the history
Co-authored-by: James McKinney <26463+jpmckinney@users.noreply.github.com>
  • Loading branch information
yolile and jpmckinney committed Jul 1, 2021
1 parent 27a2689 commit be18e0a
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 3 deletions.
4 changes: 2 additions & 2 deletions docs/local.rst
Original file line number Diff line number Diff line change
Expand Up @@ -94,11 +94,11 @@ Not all of an API's features are exposed by Kingfisher Collect. Each spider link
.. _increment:

If the filters are implemented as path parameters, you can add them to the base URL path, for example:
If the filters are implemented as path parameters, you can append path components to each URL, for example:

.. code-block:: bash
scrapy crawl spider_name -a path=path/value/path2/value2/value3
scrapy crawl spider_name -a path=key1/value1/key2/value2/value3
.. _increment:

Expand Down
3 changes: 2 additions & 1 deletion kingfisher_scrapy/util.py
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,8 @@ def wrapper(*args, **kwargs):

def add_path_param(method, path):
"""
Returns a function that yields the requests yielded by the wrapped method, after updating their path parameters.
Returns a function that yields the requests yielded by the wrapped method, after updating their path parameters'
values.
"""
def wrapper(*args, **kwargs):
for request in method(*args, **kwargs):
Expand Down

0 comments on commit be18e0a

Please sign in to comment.