fix(spiders): use date filters as part of file names #1026
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpmckinney
reviewed
Sep 19, 2023
kingfisher_scrapy/spiders/south_africa_national_treasury_api.py
Outdated
Show resolved
Hide resolved
kingfisher_scrapy/spiders/south_africa_national_treasury_api.py
Outdated
Show resolved
Hide resolved
kingfisher_scrapy/spiders/united_kingdom_contracts_finder_base.py
Outdated
Show resolved
Hide resolved
kingfisher_scrapy/spiders/united_kingdom_contracts_finder_base.py
Outdated
Show resolved
Hide resolved
yolile
commented
Sep 19, 2023
jpmckinney
force-pushed
the
fix-incremental-file-names
branch
from
d0d5512
to
b5639b4
Compare
jpmckinney
force-pushed
the
fix-incremental-file-names
branch
from
7964b33
to
5c21481
Compare
jpmckinney
reviewed
Sep 20, 2023
|
|
||
| yield scrapy.Request(url, meta={'file_name': 'page-1.json'}, callback=self.parse_page) | ||
| yield scrapy.Request(url, meta={'file_name': f'{until_date}.json'}) # reverse chronological order |
There was a problem hiding this comment.
callback=self.parse_page got deleted?
Co-authored-by: James McKinney <26463+jpmckinney@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #1025