RootPathMiddleware: Combine into multiple packages #1029
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ven if sample is set. Avoid JSON encoding (expensive). Use item['data_type'] consistently, instead of spider.data_type.
jpmckinney
force-pushed
the
rootpathmiddleware-limit
branch
from
024bb80
to
925c38b
Compare
If there are multiple releases, records or packages at the root_path, it now yields FileItems combining at most 100 of those. This causes ResizePackageMiddleware to be skipped, since ResizePackageMiddleware only processes Files – so there is no doubling of resizing.
yolile
previously approved these changes
Oct 4, 2023
…eserve existing behavior when the root_path points to an empty object.
jpmckinney
changed the title
…first in AddPackageMiddleware.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm copying some logic from ResizePackage to RootPath, but noticed some things to fix/improve.