Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: spiders: add all available publishers from Mexico Plataforma Digital Nacional #1078

Merged
merged 4 commits into from Apr 16, 2024

Conversation

yolile
Copy link
Member

@yolile yolile commented Apr 15, 2024

closes #1059

Mexico Plataforma Digital Nacional
@yolile yolile requested a review from jpmckinney April 15, 2024 20:11
…e pages_url_builder default. Use same callback name as other index spiders.
…t. Allow formatter to be None and for file_name meta to be provided (build_request already allowed overriding the file_name meta).

fix: Setting base_url changes IndexSpider's behavior
chore: Use black-style arguments for easier readability
jpmckinney
jpmckinney previously approved these changes Apr 15, 2024
Copy link
Member

@jpmckinney jpmckinney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I pushed a commit to require less overriding in the subclass.

@yolile yolile merged commit 514566d into main Apr 16, 2024
10 checks passed
@yolile yolile deleted the 1059-mexico-plataforma-digital-nacional branch April 16, 2024 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add SESAEQROO and SESEAP from Plataforma Digital Nacional
2 participants