Fix portugal scraper with json lines #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yohanna Lisnichuk <yohanitalisnichuk@gmail.com>
Signed-off-by: Yohanna Lisnichuk <yohanitalisnichuk@gmail.com>
Signed-off-by: Yohanna Lisnichuk <yohanitalisnichuk@gmail.com>
…e into 354-fix-portugal-json-lines
Signed-off-by: Yohanna Lisnichuk <yohanitalisnichuk@gmail.com>
jpmckinney
reviewed
Apr 20, 2020
Signed-off-by: Yohanna Lisnichuk <yohanitalisnichuk@gmail.com>
jpmckinney
reviewed
Apr 21, 2020
…e into 354-fix-portugal-json-lines
Signed-off-by: Yohanna Lisnichuk <yohanitalisnichuk@gmail.com>
jpmckinney
reviewed
Apr 21, 2020
jpmckinney
reviewed
Apr 21, 2020
Signed-off-by: Yohanna Lisnichuk <yohanitalisnichuk@gmail.com>
Signed-off-by: Yohanna Lisnichuk <yohanitalisnichuk@gmail.com>
|
@yolile There are a couple unresolved comments in the thread. You might have missed them due to GitHub's recent errors. |
Signed-off-by: Yohanna Lisnichuk <yohanitalisnichuk@gmail.com>
…e into 354-fix-portugal-json-lines Signed-off-by: Yohanna Lisnichuk <yohanitalisnichuk@gmail.com>
Signed-off-by: Yohanna Lisnichuk <yohanitalisnichuk@gmail.com>
jpmckinney
approved these changes
Apr 22, 2020
|
@jpmckinney I added the tests for this, I don't know why the coverage decreased? |
|
It only decreased by 0.1%. I changed the threshold in Coveralls to allow for such small changes. |
jpmckinney
added a commit
that referenced
this pull request
Apr 28, 2020
…yword arguments, closes #372
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #354