Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Warn on duplicated file name and file items #417

Merged
merged 4 commits into from
Jun 23, 2020
Merged

Warn on duplicated file name and file items #417

merged 4 commits into from
Jun 23, 2020

Conversation

yolile
Copy link
Member

@yolile yolile commented Jun 17, 2020

closes #395

@yolile
Add tests to validation pipeline
adbeb2e 
Signed-off-by: Yohanna Lisnichuk <yohanitalisnichuk@gmail.com>
@yolile
Merge branch 'master' of github.com:open-contracting/kingfisher-scrap…
b6bb7de 
…e into 395-non-unique-files-warning
@yolile yolile requested a review from jpmckinney June 17, 2020 17:54
@yolile yolile added this to In progress [6 max] in CDS 2020-05/2021-02 via automation Jun 17, 2020
jpmckinney
jpmckinney previously approved these changes Jun 23, 2020
View reviewed changes
Copy link
Member

@jpmckinney jpmckinney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I just did a little tidying. Feel free to merge if looks good to you.

@yolile
Copy link
Member Author

yolile commented Jun 23, 2020

@jpmckinney thank you! it seems like you still have to approve the merge

jpmckinney
jpmckinney approved these changes Jun 23, 2020
View reviewed changes
Copy link
Member

@jpmckinney jpmckinney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops, my second commit cancelled my review.

@yolile yolile merged commit 9896b76 into master Jun 23, 2020
CDS 2020-05/2021-02 automation moved this from In progress [6 max] to Done Jun 23, 2020
@yolile yolile deleted the 395-non-unique-files-warning branch June 23, 2020 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpmckinney jpmckinney jpmckinney approved these changes

Assignees
No one assigned
Labels
None yet
Projects
No open projects
CDS 2020-05/2021-02
  
Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Warn about non-unique file_name (and file_name/number combo)
2 participants
@yolile @jpmckinney