Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix colombia #431

Merged
merged 6 commits into from
Jun 25, 2020
Merged

Fix colombia #431

merged 6 commits into from
Jun 25, 2020

Conversation

yolile
Copy link
Member

@yolile yolile commented Jun 25, 2020

closes #430

Signed-off-by: Yohanna Lisnichuk <yohanitalisnichuk@gmail.com>
Signed-off-by: Yohanna Lisnichuk <yohanitalisnichuk@gmail.com>
Signed-off-by: Yohanna Lisnichuk <yohanitalisnichuk@gmail.com>
@yolile
Copy link
Member Author

yolile commented Jun 25, 2020

@jpmckinney I also removed the "string" type from the "data" parameter at item Shema and left it empty as there isn't a type that we can use (object type didn't worked either)

@yolile yolile requested a review from jpmckinney June 25, 2020 15:44
@jpmckinney
Copy link
Member

Right – because it's binary sometimes?

kingfisher_scrapy/item_schema/item.json Outdated Show resolved Hide resolved
kingfisher_scrapy/spiders/colombia.py Outdated Show resolved Hide resolved
kingfisher_scrapy/spiders/colombia.py Outdated Show resolved Hide resolved
Signed-off-by: Yohanna Lisnichuk <yohanitalisnichuk@gmail.com>
Signed-off-by: Yohanna Lisnichuk <yohanitalisnichuk@gmail.com>
Signed-off-by: Yohanna Lisnichuk <yohanitalisnichuk@gmail.com>
@yolile yolile requested a review from jpmckinney June 25, 2020 16:49
@yolile yolile merged commit 2e4817d into master Jun 25, 2020
@yolile yolile deleted the 430-fix-colombia branch June 25, 2020 18:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

colombia: Fix scraper file name
2 participants