Fix Chile Compra Bulk #437
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Yohanna Lisnichuk <yohanitalisnichuk@gmail.com>
Signed-off-by: Yohanna Lisnichuk <yohanitalisnichuk@gmail.com>
…e into 375-chile-bulk-fix Signed-off-by: Yohanna Lisnichuk <yohanitalisnichuk@gmail.com>
Signed-off-by: Yohanna Lisnichuk <yohanitalisnichuk@gmail.com>
aguilerapy
previously approved these changes
Jun 29, 2020
jpmckinney
reviewed
Jun 29, 2020
…e into 375-chile-bulk-fix
Signed-off-by: Yohanna Lisnichuk <yohanitalisnichuk@gmail.com>
Signed-off-by: Yohanna Lisnichuk <yohanitalisnichuk@gmail.com>
jpmckinney
previously approved these changes
Jun 30, 2020
Signed-off-by: Yohanna Lisnichuk <yohanitalisnichuk@gmail.com>
jpmckinney
reviewed
Jun 30, 2020
| 'errors': json_data, | ||
| }) | ||
| else: | ||
| return super().build_file(data=data, file_name=file_name, url=url, data_type=data_type, encoding=encoding) |
There was a problem hiding this comment.
Should we instead do data=None, **kwargs in the method signature, and then super().build_file(data=data, **kwargs) here?
There was a problem hiding this comment.
I think it is kind of the same, but I changed it
There was a problem hiding this comment.
Indeed – but this way we don't need to change two places if we add keyword arguments :)
yolile
commented
Jun 30, 2020
| @@ -67,5 +73,6 @@ def parse_list(self, response): | |||
| meta={ | |||
| 'year': year, | |||
| 'month': month, | |||
| } | |||
| }, | |||
| callback=self.parse_list | |||
There was a problem hiding this comment.
@jpmckinney sorry, I noticed that chile_base was missing a callback call in the parse_list method so I included the fix here too
Signed-off-by: Yohanna Lisnichuk <yohanitalisnichuk@gmail.com>
jpmckinney
approved these changes
Jun 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #375 #408