Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add from_date and until_date parameters to uruguay_base #445

Merged
merged 3 commits into from
Jul 13, 2020
Merged

Add from_date and until_date parameters to uruguay_base #445

merged 3 commits into from
Jul 13, 2020

Conversation

yolile
Copy link
Member

@yolile yolile commented Jul 13, 2020 •
edited
Loading

closes #444

@yolile
Add from_date and until_date parameters to uruguay_base
02ac4c0 
Signed-off-by: Yohanna Lisnichuk <yohanitalisnichuk@gmail.com>
@yolile yolile requested a review from romifz July 13, 2020 14:05
romifz
romifz previously approved these changes Jul 13, 2020
View reviewed changes
jpmckinney
jpmckinney requested changes Jul 13, 2020
View reviewed changes
kingfisher_scrapy/spiders/uruguay_base.py Outdated Show resolved Hide resolved
kingfisher_scrapy/spiders/uruguay_base.py Outdated Show resolved Hide resolved
@yolile
Change date format to YYYY-MM
ae8c9c8 
Signed-off-by: Yohanna Lisnichuk <yohanitalisnichuk@gmail.com>
@yolile yolile requested a review from jpmckinney July 13, 2020 17:25
jpmckinney
jpmckinney previously approved these changes Jul 13, 2020
View reviewed changes
Copy link
Member

@jpmckinney jpmckinney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made the change needed to avoid duplicate logic.

@yolile yolile merged commit 1dde049 into master Jul 13, 2020
@yolile yolile deleted the 444-uruguay-date-parameters branch July 13, 2020 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpmckinney jpmckinney jpmckinney approved these changes

@romifz romifz romifz left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Uruguay: add from_date and until_date parameters
3 participants
@yolile @jpmckinney @romifz