Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support rar and zip files in the same spider #602

Merged
merged 3 commits into from Jan 28, 2021
Merged

Support rar and zip files in the same spider #602

merged 3 commits into from Jan 28, 2021

Conversation

yolile
Copy link
Member

@yolile yolile commented Jan 26, 2021

ref #590

@yolile
base_spider: support rar and zip files in the same spider
75b60f5 
Signed-off-by: Yohanna Lisnichuk <yohanitalisnichuk@gmail.com>
@yolile
Update spiders that use archive_format = 'rar'
766a338 
Signed-off-by: Yohanna Lisnichuk <yohanitalisnichuk@gmail.com>
@yolile @jpmckinney
Update kingfisher_scrapy/base_spider.py
cc8be95 
Co-authored-by: James McKinney <26463+jpmckinney@users.noreply.github.com>
@yolile yolile merged commit 01eefcb into master Jan 28, 2021
@yolile yolile deleted the 590-rar-zip-spider branch January 28, 2021 15:59
@yolile yolile mentioned this pull request Feb 24, 2021
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpmckinney jpmckinney jpmckinney approved these changes

@aguilerapy aguilerapy Awaiting requested review from aguilerapy

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yolile @jpmckinney