Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CompressedFileSpider: name files including archive name #681

Merged
merged 1 commit into from Mar 19, 2021
Merged

CompressedFileSpider: name files including archive name #681

merged 1 commit into from Mar 19, 2021

Conversation

yolile
Copy link
Member

@yolile yolile commented Mar 19, 2021

closes #679

@yolile
CompressedFileSpider: name files including archive name
c578da5 
Signed-off-by: Yohanna Lisnichuk <yohanitalisnichuk@gmail.com>
@yolile yolile requested a review from jpmckinney March 19, 2021 16:04
@jpmckinney
Copy link
Member

In KingfisherFilesStore._write_file should we check that the file doesn't already exist, and error if so? I think the ZIP errors in Sentry might be related to files being rewritten.

jpmckinney
jpmckinney approved these changes Mar 19, 2021
View reviewed changes
Copy link
Member

@jpmckinney jpmckinney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agreed to update Validate pipeline as separate issue.

@yolile yolile merged commit e1ede5f into main Mar 19, 2021
@yolile yolile deleted the 679-duplicated-compressedfiles branch March 19, 2021 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpmckinney jpmckinney jpmckinney approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CompressedFileSpider: duplicate names from different compressed files
2 participants
@yolile @jpmckinney