Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make sure errors and warning columns save with SQL NULL #316

Merged
merged 1 commit into from Sep 28, 2020
Merged

Make sure errors and warning columns save with SQL NULL #316

merged 1 commit into from Sep 28, 2020

Conversation

odscjames
Copy link

#306

This commit just makes sure no new bad data is written.

@odscjames odscjames self-assigned this Sep 28, 2020
@odscjames
Make sure errors and warning columns save with SQL NULL
ae1c8c0 
#306

This commit just makes sure no new bad data is written.
Bjwebb
Bjwebb approved these changes Sep 28, 2020
View reviewed changes
Copy link

@Bjwebb Bjwebb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've not reviewed the tests in depth, but the change looks good.

@odscjames odscjames merged commit 2f4c4c5 into master Sep 28, 2020
@odscjames odscjames deleted the 306-no-null-strings-created branch September 28, 2020 13:24
@odscjames
Copy link
Author

Some warnings columns have the string "null" in them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Bjwebb Bjwebb Bjwebb approved these changes

Assignees

@odscjames odscjames

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@odscjames @Bjwebb