Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'Identifier scheme is recognized' check fails on valid scheme #31

Closed
duncandewhurst opened this issue Aug 12, 2021 · 2 comments
Closed

'Identifier scheme is recognized' check fails on valid scheme #31

duncandewhurst opened this issue Aug 12, 2021 · 2 comments
Labels
bug Something isn't working field checks Relating to field-level checks

Comments

@duncandewhurst
Copy link

https://dqt.datlab.eu/field/305/detail/parties.identifier.scheme reports failures when parties.identifier.scheme is set to NG-TIN
@jpmckinney jpmckinney transferred this issue from open-contracting-archive/pelican Sep 14, 2021
@jpmckinney jpmckinney added bug Something isn't working field checks Relating to field-level checks labels Sep 14, 2021
@jpmckinney
Copy link
Member

jpmckinney commented Oct 26, 2021 •
edited

I don't think this is a bug in Pelican. The codelist is updated whenever each dataset is analyzed. I ran the update now locally, and it pulls in NG-TIN as expected.

Although NG-TIN was added to org-id/register by the time the dataset was analyzed org-id/register#442, I'm guessing that _update_lists had not been called at org-id.guide, such that it was serving old data.

@jpmckinney jpmckinney mentioned this issue Oct 26, 2021
Closed
@jpmckinney
Copy link
Member

Although the above might be an explanation, I have identified the bug in #33. Since both require one same solution, I'll leave this closed.

jpmckinney added a commit that referenced this issue Oct 29, 2021
@jpmckinney
fix: Re-write logic for external codelists, closes #31, closes #33, c…
5427afc 
…loses #41, closes #42

The old logic would cache the results in-memory until the process was restarted.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working field checks Relating to field-level checks
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jpmckinney @duncandewhurst