general/architecture: Add code smell for skinny models

open-contracting · Nov 24, 2023 · 3d1699e · 3d1699e
1 parent b19ac40
commit 3d1699e
Showing 1 changed file with 4 additions and 0 deletions.
diff --git a/docs/general/architecture.rst b/docs/general/architecture.rst
@@ -27,3 +27,7 @@ Fat models
 ----------
 
 If a function performs `CRUD operations <https://en.wikipedia.org/wiki/Create,_read,_update_and_delete>`__ and accepts only a database session and instance values as arguments, add this function as a method on the model's class.
+
+`Code smells <https://en.wikipedia.org/wiki/Code_smell>`__ for skinny models:
+
+-  Calling database session methods outside a model's class (for example, ``COMMIT``)