You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
@kindly: If we figure that optional fields should be nullable (even if their type includes object), then we can leave the extensions as-is, I think. Do you agree?
The text was updated successfully, but these errors were encountered:
After doing more work on OCDS Merge and merging rules, I came to the conclusion that array and object fields should not be nullable (except in exceptional circumstances like GeoJSON fields), as this makes the merging logic even more complicated and non-obvious than it already is.
Follow-up to #738
In
make_versioned_release_schema.py
:minLength
when replacing sections with e.g.StringNullVersioned
title
,description
, merging properties, etc. are removed in a single, final pass.Add more patterns likeStringNullVersioned
, e.g.StringIntegerMinLength1
.ocdskit schema-report
to check, and there are no good candidates.Also, check whether to update extensions (all linked PRs refer to open-contracting/ocds-extensions#50):
/definitions/LotDetails
:null
present since first commit/definitions/Location/properties/geometry
,/definitions/Location/properties/gazetteer
: Make geometry and gazetteer nullable open-contracting-extensions/ocds_location_extension#19/definitions/Finance/properties/interestRate
: Add null type to optional fields open-contracting-extensions/ocds_finance_extension#14/definitions/Organization/properties/beneficialOwnership
: Add null type to optional fields open-contracting-extensions/ocds_shareholders_extension#16/definitions/PerformanceFailure/properties/period
: Add null type to optional fields open-contracting-extensions/ocds_performance_failures_extension#10/definitions/Observation/properties/unit
:null
present since first commit/definitions/Observation/properties/dimensions
: Make nullable open-contracting-extensions/ocds_metrics_extension#17/definitions/Observation/properties/unit
:null
present since first commit/definitions/Observation/properties/dimensions
: make dimensions nullable open-contracting-extensions/ocds_tariffs_extension#22@kindly: If we figure that optional fields should be nullable (even if their type includes object), then we can leave the extensions as-is, I think. Do you agree?
The text was updated successfully, but these errors were encountered: