Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Follow-up to versioned release schema updates #768

Closed
9 tasks done
jpmckinney opened this issue Nov 22, 2018 · 1 comment · Fixed by #769
Closed
9 tasks done

Follow-up to versioned release schema updates #768

jpmckinney opened this issue Nov 22, 2018 · 1 comment · Fixed by #769
Labels
Focus - Merging Relating to the creating of compiled releases and versioned releases
Milestone

Comments

@jpmckinney
Copy link
Member

jpmckinney commented Nov 22, 2018

Follow-up to #738

In make_versioned_release_schema.py:

  • Account for minLength when replacing sections with e.g. StringNullVersioned
  • Ensure that title, description, merging properties, etc. are removed in a single, final pass.
  • Add more patterns like StringNullVersioned, e.g. StringIntegerMinLength1.
    • I update ocdskit schema-report to check, and there are no good candidates.

Also, check whether to update extensions (all linked PRs refer to open-contracting/ocds-extensions#50):

@kindly: If we figure that optional fields should be nullable (even if their type includes object), then we can leave the extensions as-is, I think. Do you agree?

@jpmckinney jpmckinney added the Focus - Merging Relating to the creating of compiled releases and versioned releases label Nov 27, 2018
@jpmckinney jpmckinney modified the milestones: 1.1.x Clarifications, 1.1.4 Nov 27, 2018
jpmckinney pushed a commit to open-contracting/standard-maintenance-scripts that referenced this issue Dec 19, 2018
@jpmckinney
Copy link
Member Author

jpmckinney commented Mar 20, 2019

After doing more work on OCDS Merge and merging rules, I came to the conclusion that array and object fields should not be nullable (except in exceptional circumstances like GeoJSON fields), as this makes the merging logic even more complicated and non-obvious than it already is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Focus - Merging Relating to the creating of compiled releases and versioned releases
Projects
None yet
1 participant