Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add guidance on linking releases from different publications #1646

Merged
merged 15 commits into from
Mar 25, 2024
Merged

Add guidance on linking releases from different publications #1646

merged 15 commits into from
Mar 25, 2024

Conversation

duncandewhurst
Copy link
Contributor

@duncandewhurst
Copy link
Contributor Author

I suggest reviewing the HTML version of the new page as the examples are easier to parse that way.

@duncandewhurst duncandewhurst marked this pull request as ready for review October 11, 2023 04:28
odscjen
odscjen reviewed Oct 12, 2023
View reviewed changes
Copy link
Contributor

@odscjen odscjen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly all good just the one comment on when to use the link with a 'prev' relationship

docs/guidance/map/connecting_publications.md Outdated Show resolved Hide resolved
@duncandewhurst
Copy link
Contributor Author

duncandewhurst commented Oct 12, 2023 •
edited
Loading

@jpmckinney let me know if you'd prefer to review in a Google Doc.

jpmckinney
jpmckinney reviewed Oct 18, 2023
View reviewed changes
Copy link
Member

@jpmckinney jpmckinney left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed at a mid-level. That said, I don't expect I'll have much more when I read more slowly.

I haven't reviewed the Colombia case from the issue. Which example to they fall into?

docs/guidance/map.md Outdated Show resolved Hide resolved
docs/guidance/map/connecting_publications.md Outdated Show resolved Hide resolved
docs/guidance/map/connecting_publications.md Outdated Show resolved Hide resolved
docs/guidance/map/connecting_publications.md Outdated Show resolved Hide resolved
docs/guidance/map/connecting_publications.md Outdated Show resolved Hide resolved
@duncandewhurst
Copy link
Contributor Author

I haven't reviewed the Colombia case from the issue. Which example to they fall into?

The CRM issue was closed before we learned whether ANI and Colombia Compra use consistent mappings, but that seems very unlikely so I think they fall under "how to connect releases from different publications without reusing ocids".

@duncandewhurst duncandewhurst mentioned this pull request Nov 27, 2023
Open
@duncandewhurst
Copy link
Contributor Author

@jpmckinney I think this PR is awaiting your review per your comment in #1646 (comment). I'll re-request a review so that it is marked as such.

@jpmckinney jpmckinney merged commit 1ebc554 into 1.2-dev Mar 25, 2024
10 checks passed
@jpmckinney jpmckinney deleted the 1430-linking-releases-guidance branch March 25, 2024 04:06
jpmckinney added a commit to open-contracting/standard-development-handbook that referenced this pull request Apr 3, 2024
@jpmckinney
meta/style_guide: Update OCID rule in line with Primer usage open-con…
d53b63c 
…tracting/standard#1646 (comment)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yolile yolile yolile left review comments

@odscjen odscjen odscjen left review comments

@jpmckinney jpmckinney jpmckinney approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add guidance on linking releases from different publications
4 participants
@duncandewhurst @jpmckinney @yolile @odscjen