schema/: merge Project and Location extensions #1684
Conversation
|
@jpmckinney does an exception need to be added to |
I'll make the necessary changes once the PR is ready for review. |
|
Thanks @jpmckinney this is ready for review now |
|
spell check false positive, picking up on "sme" |
… but not coordinates. ci: Allow SME acronyms.
- Merge reference.md content into schema. - Copy-edit Project and Location subschema. - Copy-edit Location codelists. Remove normative word imported from RFC 7946. - Use classification scheme example that conforms to guidance. - Use "datasets" not "data sets" per style guide.
…"as it appears in a budget", then we don't need to furthermore refer to a registry.
There was a problem hiding this comment.
I made several changes. Please review. Mainly:
- Put information in the schema (which we know people read) rather than the docs (which we know people read less frequently).
- Tell people what to do, rather than tell them what not to do. This meant making budget.projectID clearer.
- Remove sentences that didn't have a lot of content.
- Don't repeat GeoJSON norms.
|
1 small typo that I've just gone ahead and corrected. Otherwise all changes look good |
|
I'm not sure that was a typo? We typically talk about a projects register (register of projects) not an (individual) "project's register". |
|
oops, sorry I'd misread the sentence! I'll do a quick PR to undo that change rather than trying to rollback seeing as the branch has already been deleted |
|
ah I see you've fixed that elsewhere, thank you! |
closes #1484
was unable to run manage.py, got the following error
which I think is because
planning/budget/projectis a string field andplanning/projectis an object.