Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BB-7012] Add github ci workflow and update requirements #100

Merged
merged 6 commits into from
Jan 23, 2023

Conversation

pkulkark
Copy link
Member

@pkulkark pkulkark commented Jan 11, 2023

Description

This PR removes the circleci workflow and replaces it with github ci. It also updates the requirements, removing python 2.7 and 3.6 support.

Supporting Information

OpenCraft Internal Jira task: BB-7012

Testing Instructions:

Verify that the new github CI tests are all passing and the xblock still functions normally.

@pkulkark pkulkark force-pushed the pooja/move-to-github-ci branch 5 times, most recently from fcb3dd2 to 78a534f Compare January 17, 2023 20:45
Copy link
Member

@Agrendalath Agrendalath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pkulkark, when I run make requirements && make test locally, there is no output after Creating test database for alias 'default'.... When I stop the process, I get the following errors:

======================================================================
ERROR: Verifies that a default poll loads, that it can be voted on, and that
----------------------------------------------------------------------
Traceback (most recent call last):
  File "/HIDDEN/xblock-poll/tests/integration/base_test.py", line 39, in setUp
    super(PollBaseTest, self).setUp()
  File "/HIDDEN/virtualenvs/tempenv-055913331076f/src/xblock-utils/xblockutils/base_test.py", line 144, in setUp
    super().setUp()
  File "/HIDDEN/virtualenvs/tempenv-055913331076f/src/xblock-utils/xblockutils/base_test.py", line 43, in setUp
    super().setUp()
  File "/HIDDEN/virtualenvs/tempenv-055913331076f/src/xblock-sdk/workbench/test/selenium_test.py", line 25, in setUp
    super().setUp()
  File "/HIDDEN/virtualenvs/tempenv-055913331076f/lib/python3.8/site-packages/bok_choy/web_app_test.py", line 121, in setUp
    self.browser = browser(tags, self.proxy)
  File "/HIDDEN/virtualenvs/tempenv-055913331076f/lib/python3.8/site-packages/bok_choy/browser.py", line 247, in browser
    browser_instance = Promise(
  File "/HIDDEN/virtualenvs/tempenv-055913331076f/lib/python3.8/site-packages/bok_choy/promise.py", line 106, in fulfill
    raise BrokenPromise(self)
bok_choy.promise.BrokenPromise: Promise not satisfied: Browser is instantiated successfully.
-------------------- >> begin captured logging << --------------------
bok_choy.browser: INFO: Using local browser: firefox [Default is firefox]
bok_choy.browser: INFO: Using default firefox profile
bok_choy.browser: INFO: Using local browser: firefox [Default is firefox]
bok_choy.browser: INFO: Using default firefox profile
bok_choy.browser: INFO: Using local browser: firefox [Default is firefox]
bok_choy.browser: INFO: Using default firefox profile
--------------------- >> end captured logging << ---------------------

Am I missing something?

tox.ini Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
.github/workflows/ci.yml Show resolved Hide resolved
.github/workflows/ci.yml Show resolved Hide resolved
.github/workflows/ci.yml Outdated Show resolved Hide resolved
requirements/dev.in Outdated Show resolved Hide resolved
requirements/dev.in Outdated Show resolved Hide resolved
requirements/dev.in Outdated Show resolved Hide resolved
Makefile Outdated Show resolved Hide resolved
.github/workflows/ci.yml Show resolved Hide resolved
@pkulkark pkulkark force-pushed the pooja/move-to-github-ci branch 7 times, most recently from f177476 to ff934b4 Compare January 20, 2023 19:58
@pkulkark pkulkark force-pushed the pooja/move-to-github-ci branch 7 times, most recently from 9346209 to 768faab Compare January 20, 2023 21:29
@pkulkark
Copy link
Member Author

@Agrendalath I couldn't figure out why, but pytest doesn't seem to work in CI. It fails with some sort of driver errors. And running tests with run_tests seems to fail with an import error related to "ctypes", on my local machine (with the same build environment). So I ended up changing the command for tox to use run_tests so that the CI tests run successfully while keeping pytest for the command make test. Does that make sense?

Copy link
Member

@Agrendalath Agrendalath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ @pkulkark, as I mentioned in this comment, browser tests still do not work for me locally. We don't need to fix it here, but please create a follow-up to look into this.

Also, please see this comment.

👍

  • I tested this: checked that the CI is passing
  • I read through the code
  • I checked for accessibility issues: n/a
  • Includes documentation: n/a
  • I made sure any change in configuration variables is reflected in the corresponding client's configuration-secure repository: n/a

@pkulkark
Copy link
Member Author

Thanks @Agrendalath. I assume you've tried both pytest as well as the run_tests version. In any case, the error message seems related to the driver. I've created BB-7068 to look into it and fix it. Will move this along.

@pkulkark pkulkark merged commit bee3c79 into pooja/publish-to-pypi Jan 23, 2023
@pkulkark pkulkark deleted the pooja/move-to-github-ci branch January 23, 2023 15:47
pkulkark added a commit that referenced this pull request Jan 30, 2023
Also adds github ci workflow and removes circleci config
as part of #100
pkulkark added a commit that referenced this pull request Feb 1, 2023
Also adds github ci workflow and removes circleci config
as part of #100
pkulkark added a commit that referenced this pull request Feb 1, 2023
Also adds github ci workflow and removes circleci config
as part of #100
pkulkark added a commit that referenced this pull request Feb 1, 2023
Also adds github ci workflow and removes circleci config
as part of #100
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants