[APP] Regression in frontend when initializing Backbone

[willroberts]

Description

There are client errors preventing us from reaching the main menu. Based on checking out one commit at a time and rebuilding, I believe this started happening in 63cc664 (Part of linting changes in #24 .

The old description below was resolved in #30

Old Description (process.env.FIREBASE_URL issue)

In c4d3352, just before #15 was merged, the app will start as expected when accessing http://localhost:3000 after running docker compose up. This is because despite process.env being empty, the following code succeeds:

# app/application.coffee
Firebase = window.Firebase = require 'firebase'
minBrowserVersionRef = new Firebase(process.env.FIREBASE_URL).child("system-status").child('browsers')

After #15, this results in an error when loading the client:

Unhandled rejection Error: FIREBASE FATAL ERROR: Cannot parse Firebase url. Please use https://<YOUR FIREBASE>.firebaseio.com 

[willroberts]

Looks like this is related to yarn build:app, which expects FIREBASE_URL to be available as an environment variable when called. In the short term, we can instead run FIREBASE_URL=<my-firebase-url> yarn build:app, but we may want to further improve the ergonomics around envify.

Edit: This is specifically caused by the removal of the default Firebase URL in config/development.json, which was previously set to https://duelyst-development.firebaseio.com/.

[willroberts]

Resolving the above reveals another error:

server_status_manager.js:32 Uncaught TypeError: DuelystFirebase.Model is not a constructor

Looking into Backbone.js to investigate:

• Model.extend() should be returning a class (with a constructor): https://github.com/jashkenas/backbone/blob/1.2.1/backbone.js#L1818L1855