Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[APP] Cleans up Envify bundler process #30

Merged
merged 13 commits into from
Sep 13, 2022
Merged

[APP] Cleans up Envify bundler process #30

merged 13 commits into from
Sep 13, 2022

Conversation

willroberts
Copy link
Collaborator

After noticing failures when missing FIREBASE_URL in gulp/bunder.js, I put this PR together to clean up the configs we bundle with envify.

Changes:

  • Updates docs with correct build commands including FIREBASE_URL
  • Cleans up gulp/bunder.js and config/config.js to remove unused configs
  • Removes more unused BNEA, PayPal, and Stripe code
  • Fixed some incorrect references, sets some defaults, and allows some config overrides from env

@willroberts willroberts mentioned this pull request Sep 13, 2022
Closed
@willroberts willroberts merged commit 72c9d7d into open-duelyst:main Sep 13, 2022
@willroberts willroberts deleted the envify-cleanup branch September 13, 2022 00:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@willroberts