Lints JavaScript code with ESLint locally and in CI #24
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This sets and enforces a consistent style for new and existing code. This PR looks ridiculous (300k lines changed...) but I've broken up the commits to make it more reviewable.
I'm making this change now in order to increase our confidence in future changes. This also paves the way to running
decaffeinate
in order to get all game code using the same style, linters, etc.Core changes:
xojs
(aneslint
wrapper) with justeslint
. Configuration is in.eslintrc.json
and.eslintignore
(see 038090c).error
towarn
to get things into a clean initial state.eslint --fix
. These changes are grouped in a single commit (63cc664) to make other changes more visible.linting
job in GitHub Actions, which is passing in testing here.100% of unit tests and an unchanged number of integration tests (87%) are still passing after this change.