-
Notifications
You must be signed in to change notification settings - Fork 151
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable clang-format from super-linter #24
Disable clang-format from super-linter #24
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
- You made this branch from
Data_lab
, so you carried over the changes to the data lab to this PR. - Isn't this too drastic? I know our coding style isn't too compatible with the clang standard, but are they that different that it requires disabling
clang-format
altogether?
clang-format is very pedantic about coding style. This commit disables is from super-linter (in the `super-linter.yml` file) and removes the configuration file `.clang-format`. Signed-off-by: Razvan Deaconescu <razvan.deaconescu@cs.pub.ro>
94d2d38
to
28ca826
Compare
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given the additional details you provided, I now believe you're right to remove clang-format
. cpplint
should suffice for basic errors such as trailing whitespaces.
3a4c0dc
to
f59a1a9
Compare
Disable clang-format from super-linter
To see how this works and the amounts of seemingly unconfigurable issues that appear:
Install using
pip
. This installs a newer 14 version.Dump the current configuration to get all (?) the configuration options:
See configuration options.
To emulate the
super-linter
behavior, run:There are
-Wclang-format-violation
warnings that we weren't able to get rid of. We didn't find the configuration options. Some situations:clang-format
requires to use a certain number of space. We didn't find any option to configure the use of tabs.clang-format
is strict to the use of spaces around arithmetic operators. For example, usingint a = b-1;
triggers a warning / error to have it written asint a = b - 1;
. This seems a bit too much and should be configurable. But again, we didn't find an option to disable this.A rather complete configuration file is the one used by cpp_weekly.