Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Evaluation Context must only contain unique values #32

Merged
merged 1 commit into from
Aug 5, 2022

Conversation

benjiro
Copy link
Member

@benjiro benjiro commented Aug 4, 2022

open-feature/spec#120

Add test to cover new requirement on evaluation context

@codecov-commenter
Copy link

Codecov Report

Merging #32 (c3f6b51) into main (4446810) will increase coverage by 0.33%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main      #32      +/-   ##
==========================================
+ Coverage   99.32%   99.66%   +0.33%     
==========================================
  Files          15       15              
  Lines         297      297              
  Branches       22       22              
==========================================
+ Hits          295      296       +1     
+ Partials        2        1       -1     
Impacted Files Coverage Δ
src/OpenFeature/Constant/Reason.cs 100.00% <ø> (ø)
src/OpenFeature/Error/FeatureProviderException.cs 100.00% <ø> (ø)
src/OpenFeature/Extension/EnumExtensions.cs 100.00% <ø> (ø)
...enFeature/Extension/ResolutionDetailsExtensions.cs 100.00% <ø> (ø)
src/OpenFeature/Hook.cs 100.00% <ø> (ø)
src/OpenFeature/Model/ClientMetadata.cs 100.00% <ø> (ø)
src/OpenFeature/Model/EvaluationContext.cs 100.00% <ø> (ø)
src/OpenFeature/Model/FlagEvaluationOptions.cs 100.00% <ø> (ø)
src/OpenFeature/Model/FlagEvalusationDetails.cs 100.00% <ø> (ø)
src/OpenFeature/Model/HookContext.cs 100.00% <ø> (ø)
... and 6 more

📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more

open-feature/spec#120

Signed-off-by: Benjamin Evenson <2031163+benjiro@users.noreply.github.com>
@beeme1mr beeme1mr merged commit 5937bb9 into main Aug 5, 2022
@beeme1mr beeme1mr deleted the chore/add-ec-test-case branch August 5, 2022 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants