Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

evaluation context requirement to allow fetching all custom fields #120

Merged
merged 5 commits into from
Aug 3, 2022

Conversation

rgrassian-split
Copy link
Contributor

No description provided.

Signed-off-by: Robert Grassian <robert.grassian@split.io>
Co-authored-by: Justin Abrahms <justin@abrah.ms>
Signed-off-by: Robert Grassian <89157164+rgrassian-split@users.noreply.github.com>
Copy link
Member

@thomaspoignant thomaspoignant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't have update the specification.json file, could you run make parse to have it in the PR ?

Signed-off-by: Robert Grassian <robert.grassian@split.io>
@beeme1mr
Copy link
Member

beeme1mr commented Aug 3, 2022

@rgrassian-split, please rerun the generator when you have a moment.

Signed-off-by: Robert Grassian <robert.grassian@split.io>
@beeme1mr beeme1mr merged commit a97fe2c into open-feature:main Aug 3, 2022
benjiro added a commit to open-feature/dotnet-sdk that referenced this pull request Aug 4, 2022
open-feature/spec#120

Signed-off-by: Benjamin Evenson <2031163+benjiro@users.noreply.github.com>
benjiro added a commit to open-feature/dotnet-sdk that referenced this pull request Aug 4, 2022
open-feature/spec#120

Signed-off-by: Benjamin Evenson <2031163+benjiro@users.noreply.github.com>
benjiro added a commit to open-feature/dotnet-sdk that referenced this pull request Aug 4, 2022
open-feature/spec#120

Signed-off-by: Benjamin Evenson <2031163+benjiro@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants