Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: adapt telemetry setup error handling #1315

Merged
merged 5 commits into from
May 27, 2024

use IMetricsRecorder consistently and fall back to Noop

155bf59
Select commit
Loading
Failed to load commit list.
Merged

chore: adapt telemetry setup error handling #1315

use IMetricsRecorder consistently and fall back to Noop
155bf59
Select commit
Loading
Failed to load commit list.
Codecov / codecov/patch succeeded May 27, 2024 in 0s

90.00% of diff hit (target 73.69%)

View this Pull Request on Codecov

90.00% of diff hit (target 73.69%)

Annotations

Check warning on line 48 in core/pkg/telemetry/metrics.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

core/pkg/telemetry/metrics.go#L48 

Added line #L48 was not covered by tests

Check warning on line 268 in flagd/pkg/service/flag-evaluation/connect_service.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flagd/pkg/service/flag-evaluation/connect_service.go#L268 

Added line #L268 was not covered by tests

Check warning on line 44 in flagd/pkg/service/middleware/metrics/http_metrics.go

See this annotation in the file changed.

@codecov codecov / codecov/patch

flagd/pkg/service/middleware/metrics/http_metrics.go#L44 

Added line #L44 was not covered by tests
View more details on Codecov