fix: targeting key sometimes missing in rule context #676
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kavindu-Dodan
force-pushed
the
fix/add-explicit-targeting-key
branch
from
60a017e
to
535f89f
Compare
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
Kavindu-Dodan
force-pushed
the
fix/add-explicit-targeting-key
branch
from
535f89f
to
7028309
Compare
toddbaert
approved these changes
Feb 13, 2024
toddbaert
changed the title
toddbaert
approved these changes
Feb 13, 2024
DBlanchard88
pushed a commit
to DBlanchard88/java-sdk-contrib
that referenced
this pull request
Apr 29, 2024
…ure#676) Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR
Fixes a bug that failed to extract the targeting key when set through the constructor.
When set through the constructor,
exposed methods such as
ctc.asObjectMap()orctx.asMap()does not include the targeting key set at constructor. This PR fixes this by explicitly getting and adding the targeting key for downstream payloads.