Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: targeting key sometimes missing in rule context #676

Merged

Conversation

Kavindu-Dodan
Copy link
Collaborator

This PR

Fixes a bug that failed to extract the targeting key when set through the constructor.

When set through the constructor,

 var ctx = new ImmutableContext("TargetingKey")

exposed methods such as ctc.asObjectMap() or ctx.asMap() does not include the targeting key set at constructor. This PR fixes this by explicitly getting and adding the targeting key for downstream payloads.

Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
Signed-off-by: Kavindu Dodanduwa <kavindudodanduwa@gmail.com>
@toddbaert toddbaert changed the title fix: targeting key extraction when set through the constructor fix: targeting key sometimes missing in rule context Feb 13, 2024
@toddbaert toddbaert merged commit 7407b84 into open-feature:main Feb 13, 2024
5 checks passed
DBlanchard88 pushed a commit to DBlanchard88/java-sdk-contrib that referenced this pull request Apr 29, 2024
…ure#676)

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants