Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add flag metadata #502

Merged
merged 2 commits into from
Jul 28, 2023
Merged

feat: add flag metadata #502

merged 2 commits into from
Jul 28, 2023

Conversation

toddbaert
Copy link
Member

This PR:

  • adds flag metadata
  • renames GRPCService file to be consistent
  • adds relevant assertions, improves unrelated tests

@toddbaert toddbaert requested a review from a team as a code owner July 28, 2023 17:57
@github-actions github-actions bot requested a review from beeme1mr July 28, 2023 17:57
beeme1mr
beeme1mr approved these changes Jul 28, 2023
View reviewed changes
Copy link
Member

@beeme1mr beeme1mr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved but please add a table to the docs showing what flag metadata is supported.

@toddbaert
feat: add flag metadata
f01e520 
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
@toddbaert
fixup: readme
12898f9 
Signed-off-by: Todd Baert <todd.baert@dynatrace.com>
@toddbaert toddbaert merged commit c8a80c6 into main Jul 28, 2023
6 checks passed
@github-actions github-actions bot mentioned this pull request Jul 28, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@beeme1mr beeme1mr beeme1mr approved these changes

Assignees

@beeme1mr beeme1mr

@toddbaert toddbaert

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@toddbaert @beeme1mr