-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: implement draft for a Nest.js SDK #718
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks similar to what I am having at work
Just also added the |
Yep that works for me! You'll have to manually add an entry in https://github.com/open-feature/js-sdk/blob/main/.release-please-manifest.json though. |
Great, changed that. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me as an experimental release!
I added a couple more suggestions.
Signed-off-by: Lukas Reining <lukas.reining@codecentric.de>
…context Signed-off-by: Lukas Reining <lukas.reining@codecentric.de>
Signed-off-by: Lukas Reining <lukas.reining@codecentric.de>
Co-authored-by: Henry Chen <1474479+chenhunghan@users.noreply.github.com> Co-authored-by: Luiz Guilherme Ribeiro <ltrindaderibeiro@gmail.com> Signed-off-by: Lukas Reining <lukas.reining@codecentric.de>
Co-authored-by: Henry Chen <1474479+chenhunghan@users.noreply.github.com> Signed-off-by: Lukas Reining <lukas.reining@codecentric.de>
Co-authored-by: Henry Chen <1474479+chenhunghan@users.noreply.github.com> Signed-off-by: Lukas Reining <lukas.reining@codecentric.de>
Signed-off-by: Lukas Reining <lukas.reining@codecentric.de>
Co-authored-by: Todd Baert <todd.baert@dynatrace.com> Signed-off-by: Lukas Reining <lukas.reining@codecentric.de>
Signed-off-by: Lukas Reining <lukas.reining@codecentric.de>
Signed-off-by: Lukas Reining <lukas.reining@codecentric.de>
Signed-off-by: Lukas Reining <lukas.reining@codecentric.de>
Signed-off-by: Lukas Reining <lukas.reining@codecentric.de>
Signed-off-by: Lukas Reining <lukas.reining@codecentric.de>
df5d164
to
df70937
Compare
Signed-off-by: Lukas Reining <lukas.reining@codecentric.de>
Signed-off-by: Lukas Reining <lukas.reining@codecentric.de>
I would merge this now, so we can work together on different questions. |
🤖 I have created a release *beep* *boop* --- ## [0.0.2-experimental](nestjs-sdk-v0.0.1-experimental...nestjs-sdk-v0.0.2-experimental) (2023-12-13) ### ✨ New Features * implement draft for a Nest.js SDK ([#718](#718)) ([ef874e0](ef874e0)) ### Dependencies * The following workspace dependencies were updated * devDependencies * @openfeature/core bumped from * to 0.0.21 * @openfeature/server-sdk bumped from * to 1.8.0 --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Signed-off-by: OpenFeature Bot <109696520+openfeaturebot@users.noreply.github.com> Signed-off-by: Todd Baert <todd.baert@dynatrace.com> Co-authored-by: Todd Baert <todd.baert@dynatrace.com>
<!-- Please use this template for your pull request. --> <!-- Please use the sections that you need and delete other sections --> ## This PR <!-- add the description of the PR here --> This is a first draft of a Nest.js SDK. Currently it only handles injecting clients and feature flags. I also added a context factory for the FeatureFlag decorators to be able to use request information for the execution context. ### Related Issues <!-- add here the GitHub issue that this PR resolves if applicable --> Fixes #705 ### Notes <!-- any additional notes for this PR --> @toddbaert maybe we can do it as we did with the React SDK, merge this fast and release as experimental to let people experiment and try out? ### Follow-up Tasks <!-- anything that is related to this PR but not done here should be noted under this section --> <!-- if there is a need for a new issue, please link it here --> We will have to see if we want to stick with the injected feature flags being wrapped in an observable. To me this feels the most idiomatic for Nest.js. ### How to test Tests for the current functionality are included. --------- Signed-off-by: Lukas Reining <lukas.reining@codecentric.de> Co-authored-by: Henry Chen <1474479+chenhunghan@users.noreply.github.com> Co-authored-by: Luiz Guilherme Ribeiro <ltrindaderibeiro@gmail.com> Co-authored-by: Todd Baert <todd.baert@dynatrace.com>
🤖 I have created a release *beep* *boop* --- ## [0.0.2-experimental](nestjs-sdk-v0.0.1-experimental...nestjs-sdk-v0.0.2-experimental) (2023-12-13) ### ✨ New Features * implement draft for a Nest.js SDK ([#718](#718)) ([ef874e0](ef874e0)) ### Dependencies * The following workspace dependencies were updated * devDependencies * @openfeature/core bumped from * to 0.0.21 * @openfeature/server-sdk bumped from * to 1.8.0 --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Signed-off-by: OpenFeature Bot <109696520+openfeaturebot@users.noreply.github.com> Signed-off-by: Todd Baert <todd.baert@dynatrace.com> Co-authored-by: Todd Baert <todd.baert@dynatrace.com>
This PR
This is a first draft of a Nest.js SDK.
Currently it only handles injecting clients and feature flags.
I also added a context factory for the FeatureFlag decorators to be able to use request information for the execution context.
Related Issues
Fixes #705
Notes
@toddbaert maybe we can do it as we did with the React SDK, merge this fast and release as experimental to let people experiment and try out?
Follow-up Tasks
We will have to see if we want to stick with the injected feature flags being wrapped in an observable.
To me this feels the most idiomatic for Nest.js.
How to test
Tests for the current functionality are included.