chore: react-sdk | downgrading react peer dependency | react 18.0.0 -> 16.8.0 #742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is the version when react hooks were introduced. Signed-off-by: Shujaat Ali <dr.shujaat_ali@hotmail.com>
shujieali
changed the title
shujieali
changed the title
shujieali
changed the title
shujieali
changed the title
|
Soon we will be adding suspense support with this PR. Before 18, suspense worked differently, so I'm not 100% sure it will work as we want. I will test it and if things seem ok, we can make this change. I'll get to this early next week. |
|
Hey @shujieali ! I tested this in my upcoming React PR which ads suspense support, as well as 2-3 other nice features, and it works fine. Thanks for the suggestion, merging. |
toddbaert
approved these changes
Jan 11, 2024
github-merge-queue bot
pushed a commit
that referenced
this pull request
Jan 11, 2024
🤖 I have created a release *beep* *boop* --- ## [0.0.6-experimental](react-sdk-v0.0.5-experimental...react-sdk-v0.0.6-experimental) (2024-01-11) ### ✨ New Features * suspense support, client scoping, context-sensitive re-rendering ([#759](#759)) ([8f01ead](8f01ead)) ### 🧹 Chore * fix React SDK README.md to use the resolved value instead of the resolution details ([#691](#691)) ([2d1b8eb](2d1b8eb)) * react-sdk | downgrading react peer dependency | react 18.0.0 -> 16.8.0 ([#742](#742)) ([2c864e4](2c864e4)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Signed-off-by: OpenFeature Bot <109696520+openfeaturebot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fix the npm warning when installing @openfeature/react-sdk in application using react version < 18
Fixes #741
How to test
useFeatureFlagin application as per documentation with no issue.