Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Evaluation Context related error status #141

Closed
kinyoklion opened this issue Sep 22, 2022 · 3 comments
Closed

Evaluation Context related error status #141

kinyoklion opened this issue Sep 22, 2022 · 3 comments
Assignees

Comments

@kinyoklion
Copy link
Member

For some providers contexts are going to require certain attributes to function correctly. For instance a targeting key.

It would be good if there was an error code for context related problems, for instance MALFORMED_CONTEXT.

This would help to more quickly narrow down usage errors.

@toddbaert
Copy link
Member

I agree this would be helpful. I'd accept MALFORMED_CONTEXT, but I'll also suggest INVALID_CONTEXT as another possible alternative. "Malformed" suggests to me something like a structural error, while "invalid" implies either structural or semantic issues (like a missing targeting key). I think either work though.

@thomaspoignant
Copy link
Member

Yes it would be great to have something like that in the providers to be explicit when a field is missing.

beeme1mr pushed a commit that referenced this issue Sep 27, 2022
See #141 for context.

Signed-off-by: Ryan Lamb <4955475+kinyoklion@users.noreply.github.com>
Co-authored-by: Todd Baert <toddbaert@gmail.com>
@kinyoklion
Copy link
Member Author

Resolved in #142

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

6 participants