Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat!: make error code an enum and include optional error message #142

Merged
merged 14 commits into from
Sep 27, 2022
Merged

feat!: make error code an enum and include optional error message #142

merged 14 commits into from
Sep 27, 2022

Commits on Sep 23, 2022

  1. Add INVALID_CONTEXT error code. 

    Signed-off-by: Ryan Lamb <4955475+kinyoklion@users.noreply.github.com>
    @kinyoklion
    kinyoklion committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    d5f5128 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into rlamb/invalid-context

    @kinyoklion
    kinyoklion committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    886ec0b View commit details
    Browse the repository at this point in the history

  3. Enumerate error codes in a table. Link to error codes from flag evalu… 

    …ation, versus having samples. Update providers 2.8 to be consistent with the table.

Signed-off-by: Ryan Lamb <4955475+kinyoklion@users.noreply.github.com>
    @kinyoklion
    kinyoklion committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    24dba1a View commit details
    Browse the repository at this point in the history

  4. Update json specification. 

    Signed-off-by: Ryan Lamb <4955475+kinyoklion@users.noreply.github.com>
    @kinyoklion
    kinyoklion committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    833af07 View commit details
    Browse the repository at this point in the history

  5. Linting updates. 

    Signed-off-by: Ryan Lamb <4955475+kinyoklion@users.noreply.github.com>
    @kinyoklion
    kinyoklion committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    19d0620 View commit details
    Browse the repository at this point in the history

  6. Change 'error codes' to 'error code'. 

    Signed-off-by: Ryan Lamb <4955475+kinyoklion@users.noreply.github.com>
    @kinyoklion
    kinyoklion committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    2b23695 View commit details
    Browse the repository at this point in the history

  7. Remove inadverant pipe on note. 

    Signed-off-by: Ryan Lamb <4955475+kinyoklion@users.noreply.github.com>
    @kinyoklion
    kinyoklion committed Sep 23, 2022
    Configuration menu
    Copy the full SHA
    3db6249 View commit details
    Browse the repository at this point in the history

Commits on Sep 26, 2022

  1. Remove the enumerated values from 2.8 and reference the error code type. 

    Signed-off-by: Ryan Lamb <4955475+kinyoklion@users.noreply.github.com>
    @kinyoklion
    kinyoklion committed Sep 26, 2022
    Configuration menu
    Copy the full SHA
    f8f17d7 View commit details
    Browse the repository at this point in the history

  2. Update spec JSON. 

    Signed-off-by: Ryan Lamb <4955475+kinyoklion@users.noreply.github.com>
    @kinyoklion
    kinyoklion committed Sep 26, 2022
    Configuration menu
    Copy the full SHA
    fcbcb00 View commit details
    Browse the repository at this point in the history

  3. Change 1.4.7 to use an error code instead of a string. 

    Signed-off-by: Ryan Lamb <4955475+kinyoklion@users.noreply.github.com>
    @kinyoklion
    kinyoklion committed Sep 26, 2022
    Configuration menu
    Copy the full SHA
    fec8633 View commit details
    Browse the repository at this point in the history

  4. Add requirement for error message. 

    Signed-off-by: Ryan Lamb <4955475+kinyoklion@users.noreply.github.com>
    @kinyoklion
    kinyoklion committed Sep 26, 2022
    Configuration menu
    Copy the full SHA
    5c93e9b View commit details
    Browse the repository at this point in the history

  5. Update specification/sections/01-flag-evaluation.md 

    Co-authored-by: Todd Baert <toddbaert@gmail.com>
Signed-off-by: Ryan Lamb <4955475+kinyoklion@users.noreply.github.com>
    @kinyoklion @toddbaert
    kinyoklion and toddbaert committed Sep 26, 2022
    Configuration menu
    Copy the full SHA
    0e4007b View commit details
    Browse the repository at this point in the history

  6. Update specficiation.json, extend 2.8 with optional error message. 

    Signed-off-by: Ryan Lamb <4955475+kinyoklion@users.noreply.github.com>
    @kinyoklion
    kinyoklion committed Sep 26, 2022
    Configuration menu
    Copy the full SHA
    766164f View commit details
    Browse the repository at this point in the history

  7. Add example exception. 

    Signed-off-by: Ryan Lamb <4955475+kinyoklion@users.noreply.github.com>
    @kinyoklion
    kinyoklion committed Sep 26, 2022
    Configuration menu
    Copy the full SHA
    a0ee5b1 View commit details
    Browse the repository at this point in the history