🔥 [#1451] -- delete display_value template tag

This has been superceded by the renderer interface

setup.cfg

@@ -47,6 +47,7 @@ omit =
     src/openforms/registrations/contrib/email/views.py
 
 [coverage:report]
+skip_covered = True
 omit =
     manage.py
     */tests/test_*

src/openforms/emails/templatetags/form_summary.py

@@ -30,30 +30,3 @@ def summary(context):
 @register.simple_tag()
 def whitespace(amount: int, base=" ") -> str:
     return base * amount
-
-
-@register.simple_tag(takes_context=True)
-def display_value(context, value: Any):
-    warnings.warn(
-        "The {% display_value %} template tag is deprecated, please use "
-        "'openforms.submissions.rendering.renderer.Renderer' instead.",
-        DeprecationWarning,
-    )
-    _is_html = not context.get("rendering_text", False)
-    if isinstance(value, dict) and value.get("originalName"):
-        # uploads
-        return value["originalName"]
-    if isinstance(value, (list, tuple)):
-        return "; ".join(display_value(context, v) for v in filter(None, value))
-
-    # output - see if we have something that can output as html and as plain text
-    method = "as_html" if _is_html else "as_plain_text"
-    formatter = getattr(value, method, None)
-    if formatter is not None and callable(formatter):
-        return formatter()
-
-    if value is None:
-        return ""
-    else:
-        # fall back to default of string representation
-        return force_str(value)

src/openforms/formio/formatters/tests/test_kitchensink.py

@@ -1,6 +1,5 @@
 from django.utils.translation import gettext as _
 
-from openforms.emails.templatetags.form_summary import display_value
 from openforms.submissions.tests.factories import (
     SubmissionFactory,
     SubmissionFileAttachmentFactory,
@@ -99,16 +98,7 @@ def run_kitchensink_test(self, name_data, name_printable):
         # check if we have something for all components
         self.assertEqual(set(d[0] for d in printable_data), expected_labels)
 
-        text_values = dict()
-        for label, value in printable_data:
-            text_values[label] = display_value({"rendering_text": True}, value)
-
-        html_values = dict()
-        for label, value in printable_data:
-            html_values[label] = display_value({"rendering_text": False}, value)
-
-        # check if text and html values are same
-        self.assertEqual(text_values, html_values)
+        text_values = dict(printable_data)
 
         for label, value in text_printed.items():
             with self.subTest(f"{label} -> '{value}'"):
@@ -129,17 +119,7 @@ def test_appointments_formio(self):
         )
 
         printable_data = _get_printable_data(submission)
-
-        text_values = dict()
-        for label, value in printable_data:
-            text_values[label] = display_value({"rendering_text": True}, value)
-
-        html_values = dict()
-        for label, value in printable_data:
-            html_values[label] = display_value({"rendering_text": False}, value)
-
-        # check if text and html values are same
-        self.assertEqual(text_values, html_values)
+        text_values = dict(printable_data)
 
         for label, value in text_printed.items():
             with self.subTest(f"{label} -> '{value}'"):